Skip to content

Removed commented code#17346

Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
mage2pratik:remove-commented-code-6
Aug 26, 2018
Merged

Removed commented code#17346
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
mage2pratik:remove-commented-code-6

Conversation

@mage2pratik
Copy link
Copy Markdown
Contributor

@mage2pratik mage2pratik commented Aug 3, 2018 •
edited
Loading

Description

Removed commented code and make it cleaner more.

Fixed Issues (if relevant)

  1. Removed commented code #17316: Removed commented code

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 3, 2018

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev ihor-sviziev self-assigned this Aug 3, 2018
orlangur
orlangur requested changes Aug 3, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore comments in generators except Code/Generator/Repository.php as they are useful. Do amend commit and force push.

@orlangur orlangur self-assigned this Aug 3, 2018
@ihor-sviziev ihor-sviziev removed their assignment Aug 3, 2018
@VladimirZaets VladimirZaets self-assigned this Aug 7, 2018
@orlangur orlangur removed the request for review from ihor-sviziev August 8, 2018 23:38
@orlangur
Copy link
Copy Markdown
Contributor

orlangur commented Aug 8, 2018

@mage2pratik please apply necessary changes instead of requesting a review.

@ihor-sviziev ihor-sviziev requested a review from orlangur August 16, 2018 15:25
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 17, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 17, 2018

Hi @orlangur, thank you for the review.
ENGCOM-2818 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit f833fda into magento:2.3-develop Aug 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2018
ENGCOM-2818: Removed commented code #17346
4d267a5
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 26, 2018

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@lewisvoncken lewisvoncken mentioned this pull request Oct 6, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@VladimirZaets VladimirZaets

Labels

Area: Frontend Cleanup Component: Framework/ObjectManager Component: Widget Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mage2pratik @magento-engcom-team @orlangur @ihor-sviziev @VladimirZaets